Skip to content
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.

ACS-1689-import-measures-rake #640

Open
wants to merge 100 commits into
base: r5
Choose a base branch
from

Conversation

jessigu
Copy link

@jessigu jessigu commented Dec 19, 2019

Pull requests into Health Data Standards require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • This PR is into the correct branch.
  • Internal ticket for this PR:
  • Internal ticket links back to this PR
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • Tests are included and test edge cases
  • Tests have been run locally and pass
  • Code coverage has not gone down and all code touched or added is covered.
    • In rare situations, this may not be possible or applicable to a PR. In those situations:
      1. Note why this could not be done or is not applicable here:
      2. Add TODOs in the code noting that it requires a test
      3. Add a JIRA task to add the test and link it here:

Cypress Reviewer:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Bonnie Reviewer:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

peter li and others added 29 commits September 4, 2019 14:53
Update facility departure datetime
backward compatibility bug fix
Added mappings to negated elements
see pull request 43 for update to departure datetime
Update to include correct time for facility
I found a bug that occurs when the QRDA cat 1, contains two communication from provider to provider elements, each one referencing to different referral interventions. 

If you upload a QRDA cat 1 with only one communication from provider to provider, the error never happens.
When uploading a QRDA cat 1 with a substance of administration that contains repeatNumber with a value. Pophealth is throwing an exception.  Now it works after the change I made
pophealth QRDA cat 1 throws and exception when repeatnumber is present
Add support for submitting CAT3 for MIPS CMS program
This reverts commit 35815ec.
@jessigu jessigu changed the base branch from master to r5 December 19, 2019 02:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants