This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
Fix map reduce infinite loop error #348
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 25, 2016 16:49
Duplicate `:medications` information was causing the `map_fn` for `Child Immunization Status (40280381-4555-E1C1-0145-D7C003364261)` to go into an infinite loop during mongo's mapreduce, eating up 100% CPU, and eventually causing a memory leak. Although the `BulkRecordImporter` calls `PatientImporter` which calls `Record`'s `dedup_record!` method, the `:medications` sections still were not being deduped. This fix uses ruby's `uniq` method to dedupe `:medications` rather than using more domain-specific approaches. This fixes the infinite loop error, and turns the corresponding Cypress tests green.
* Rename `dedup_section_naively!` * Add fixture of duplicated medications patient * Add MiniTest to ensure `dudup_record!` works as expected
Continuous integration seems to have a problem finding the record we need to run `test_dedup_section_naively`. Adding loading of collection fixtures in `setup` method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting from q-centrix#6:
It looks like this measure was skipped in Cypress for a while: projectcypress/cypress@450178b
Someone else commenting with the same issue: WorldVistA/popHealth#1 (comment)
Identified as an issue by the pophealth team: http://issues.osehra.org/browse/POP-270
Please let me know if this is not the correct approach! I am using these commits in a fork currently and would like to update if there's a better solution.