Skip to content
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.

Namespaced models. #228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Wylan
Copy link

@Wylan Wylan commented Nov 28, 2014

We ran into a similar issue as in #40. All the classes in the lib/models directory have been namespaced, and all calls to them updated with the namespace.

@eedrummer
Copy link
Contributor

Thanks for the PR and sorry for taking so long to get back on this. IMHO, this is a good idea. I intend to merge this in, but it has ripple effects for the projects that depend on it (Bonnie, Cypress, popHealth, etc.)

I'm going to talk with other developers on those projects to develop a strategy for getting this merged in and released.

@Wylan
Copy link
Author

Wylan commented Dec 12, 2014

Sounds good, I figured that there would be some issues merging it because it will cause some breaking changes. I'm glad to have been able to contribute something useful back to the project.

@dillonwelch
Copy link

👍 for doing something like this. I'm working on a project using HealthDataStandards and have encountered a naming clash.

Perhaps it's something that could be done in stages? One to a few models at a time?

@dillonwelch
Copy link

Created https://github.com/projectcypress/health-data-standards/pull/447 as a compromise attempt at this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants