Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-6940 Update gitleaks.yml #4

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

riddhi-desai
Copy link
Contributor

Replaced madie-measure with excel-export for gitleaks workflow

MADiE PR

Jira Ticket: MAT-6940
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

Replaced madie-measure with excel-export for gitleaks workflow
@riddhi-desai riddhi-desai requested a review from a team as a code owner March 19, 2024 14:56
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (76c54e4) 50 50 100.00%
Head commit (f0cc405) 50 (+0) 50 (+0) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (76c54e4) to head (f0cc405).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop       #4   +/-   ##
========================================
  Coverage    98.00%   98.00%           
========================================
  Files            6        6           
  Lines           50       50           
  Branches         3        3           
========================================
  Hits            49       49           
  Partials         1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@riddhi-desai riddhi-desai merged commit e781fad into develop Mar 19, 2024
13 checks passed
@riddhi-desai riddhi-desai deleted the MAT-6940-gitleaks.yml-change branch March 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants