Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add close() methods throughout the SecureJar->JarContents chain to allow closing the backing file systems #68

Merged
merged 5 commits into from
Jun 2, 2024
Merged

Add close() methods throughout the SecureJar->JarContents chain to allow closing the backing file systems #68

merged 5 commits into from
Jun 2, 2024

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Apr 12, 2024

BREAKING CHANGE

@marchermans marchermans self-requested a review April 25, 2024 18:58
@shartte shartte requested a review from Matyrobbrt June 2, 2024 18:18
@shartte shartte merged commit 503aae8 into McModLauncher:main Jun 2, 2024
1 check passed
@shartte shartte deleted the autoclosable branch June 2, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matyrobbrt Matyrobbrt Matyrobbrt approved these changes

@marchermans marchermans marchermans approved these changes

@Technici4n Technici4n Awaiting requested review from Technici4n

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shartte @marchermans @Technici4n @Matyrobbrt