Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute jar module descriptors in parallel #57

Merged
merged 4 commits into from
Nov 26, 2023

Conversation

Technici4n
Copy link
Contributor

@Technici4n Technici4n commented Nov 26, 2023

To compute a module descriptor, we need to compute the package list, and that is often slow. So do it in parallel! (And defer computation of the module descriptor until it is actually needed).

Also added a new method to retrieve the provided services without computing the full module descriptor, for use in the ModDirTransformerDiscoverer.

Tested in ATM8.

@marchermans marchermans merged commit 0721081 into McModLauncher:main Nov 26, 2023
1 check passed
This was referenced Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants