Skip to content

Commit

Permalink
Remove AutoClosable from SecureJar to prevent spurious warnings on al…
Browse files Browse the repository at this point in the history
…l getters that return it
  • Loading branch information
shartte committed Jun 2, 2024
1 parent 797e232 commit d2c3d97
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
7 changes: 1 addition & 6 deletions src/main/java/cpw/mods/jarhandling/SecureJar.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,14 @@
import java.security.CodeSigner;
import java.util.List;
import java.util.Optional;
import java.util.Set;
import java.util.function.BiPredicate;
import java.util.function.Function;
import java.util.function.Supplier;
import java.util.jar.Attributes;
import java.util.jar.Manifest;

/**
* A secure jar is the full definition for a module,
* including all its paths and code signing metadata.
*/
public interface SecureJar extends AutoCloseable {
public interface SecureJar {
/**
* Creates a jar from a list of paths.
* See {@link JarContentsBuilder} for more configuration options.
Expand Down Expand Up @@ -90,7 +86,6 @@ static SecureJar from(JarContents contents, JarMetadata metadata) {
* Closes the underlying file system resources (if any).
* Renders this object unusable.
*/
@Override
void close() throws IOException;

/**
Expand Down
1 change: 0 additions & 1 deletion src/main/java/cpw/mods/jarhandling/impl/Jar.java
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import cpw.mods.jarhandling.JarMetadata;
import cpw.mods.jarhandling.SecureJar;
import cpw.mods.niofs.union.UnionFileSystem;
import cpw.mods.niofs.union.UnionPathFilter;
import cpw.mods.util.LambdaExceptionUtils;
import org.jetbrains.annotations.Nullable;

Expand Down

0 comments on commit d2c3d97

Please sign in to comment.