Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Text Field #203

Merged
merged 13 commits into from
Jan 23, 2025
Merged

Add Text Field #203

merged 13 commits into from
Jan 23, 2025

Conversation

camdnnn
Copy link
Contributor

@camdnnn camdnnn commented Jan 20, 2025 •
edited
Loading

Added the text field component matching the specification from the Figma design

image

@camdnnn camdnnn added enhancement New feature or request frontend Involves the React Typescript frontend labels Jan 20, 2025
@camdnnn camdnnn added this to the UI / UX Redesign milestone Jan 20, 2025
@camdnnn camdnnn requested a review from gr812b January 20, 2025 01:25
@camdnnn camdnnn self-assigned this Jan 20, 2025
@camdnnn camdnnn linked an issue Jan 20, 2025 that may be closed by this pull request
UI - Text Field #164
Closed
@camdnnn camdnnn marked this pull request as ready for review January 20, 2025 01:46
gr812b
gr812b requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@gr812b gr812b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few minor details

front-end/src/components/App.tsx Outdated Show resolved Hide resolved
front-end/src/components/App.tsx Outdated Show resolved Hide resolved
front-end/src/components/textfield/TextField.tsx Outdated Show resolved Hide resolved
front-end/src/components/textfield/TextField.tsx Outdated Show resolved Hide resolved
front-end/src/styles/_variables.scss Outdated Show resolved Hide resolved
@gr812b
Copy link
Collaborator

gr812b commented Jan 20, 2025

Can you also show variant without label?

@camdnnn
Copy link
Contributor Author

camdnnn commented Jan 20, 2025

Can you also show variant without label?

image

@camdnnn camdnnn requested a review from gr812b January 20, 2025 19:23
gr812b
gr812b requested changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@gr812b gr812b left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have a default placeholder text such as 'Value' or smt.

Text in the input should be left alligned I feel. Just have some sort of padding on the left of it to offset by a certain amount. Figma is wrong in this case IMO. This is just for when its longer it looks a bit silly
image

When the parent element is small enough, the text field seems to not shrink down (some reason the minimum is 195) I did some investigating and have no fckin clue why this happens, but looks to me like width:100%; fixed it on the input class
image

front-end/src/components/textfield/TextField.module.scss Outdated Show resolved Hide resolved
@camdnnn camdnnn requested a review from gr812b January 21, 2025 19:29
@camdnnn camdnnn merged commit 738324f into main Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr812b gr812b gr812b approved these changes

Assignees

@camdnnn camdnnn

Labels
enhancement New feature or request frontend Involves the React Typescript frontend
Projects
None yet
Milestone
UI / UX Redesign
Development

Successfully merging this pull request may close these issues.

UI - Text Field
2 participants
@camdnnn @gr812b