Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latitude vs longitude 1:1 #199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

switzmab
Copy link
Contributor

Ensures longitude and latitude maintain a 1:1 ratio when window is resized

Ensures longitude and latitude maintain a 1:1 ratio when window is resized
@switzmab switzmab linked an issue Jan 14, 2025 that may be closed by this pull request
@switzmab switzmab requested a review from gr812b January 15, 2025 20:36
Comment on lines +81 to +86
if(width!=undefined && height!=undefined) {
const size = Math.min(width ,height);
chartRef.current.setSize(size,size);
}else {
chartRef.current.setSize(width,height);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faiirrlly certain this would only make the graph itself a square, but not concern itself with the scale of the axes. Taking a look into it now

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also still applies to all graphs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

This is just an example, but if you see here the axes not being to scale, then it doesn't exactly solve the issue here. Just making the graph itself a square doesn't resolve the sizes being off regardless. On the y, we have 0-300k and on the x 0-50k, which is a big difference in scale

Comment on lines +81 to +86
if(width!=undefined && height!=undefined) {
const size = Math.min(width ,height);
chartRef.current.setSize(size,size);
}else {
chartRef.current.setSize(width,height);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

This is just an example, but if you see here the axes not being to scale, then it doesn't exactly solve the issue here. Just making the graph itself a square doesn't resolve the sizes being off regardless. On the y, we have 0-300k and on the x 0-50k, which is a big difference in scale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latitude VS Longitude Graph Scale
2 participants