More recipe caching #197
Open
More recipe caching #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caching used recipes when updating the client-side inventory reduces client freezes when there are a lot of recipes registered.
Reduces freezing upon opening a crafter when there is a large number of recipes registered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When playing on the ATM9 modpack I noticed every time I opened a crafter with a bunch of recipes my game froze for a moment. The same happened when a
ClientboundContainerSetContentPacketwas sent (i.e. when shift-clicking and moving multiple items into the crafter at once) although the pause took longer in this case.Commit b1ef472 fixes the second issue, while 49e53f2 the first one