Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove text from DM button, stops excessive text wrap on desktop view with three columns #882

Merged
2 commits merged into from
Jul 2, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jul 2, 2024

PR removes the text from the DM button, stops the smooshed text wrapping on desktop view with 3 column view enabled:

Before:
image

image

After:
image

image

The envelope icon should be enough to get the point across that this is to message the user... also consider we do the same thing already with the mobile view <span class="hide-on-mobile">. I've retained the hover over text fwiw, not that it matters much on mobile anyway.... but at least it will show the translation on desktop

@ghost ghost added low priority does not impact production code frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end labels Jul 2, 2024
@BentiGorlich BentiGorlich assigned ghost Jul 2, 2024
@BentiGorlich
Copy link
Member

Not to add it in this PR, but what do you think about removing the text of the follow and block button as well? If we add a title attribute there it will still show the tooltip on hover. Though I don't know how we could make that work on mobile...

@ghost
Copy link
Author

ghost commented Jul 2, 2024

Not to add it in this PR, but what do you think about removing the text of the follow and block button as well? If we add a title attribute there it will still show the tooltip on hover. Though I don't know how we could make that work on mobile...

@e-five256 and I talked about that and we agreed not having text next to those other buttons may not be intuitive enough on mobile without the tooltip vs the prolific envelope icon meaning"message". A better implementation might be adding a new row so the buttons have more room... but I'll let someone else with better UI skills tackle that, lol.

@ghost ghost enabled auto-merge (squash) July 2, 2024 11:47
@ghost ghost merged commit 0ce231c into main Jul 2, 2024
7 checks passed
@ghost ghost deleted the remove_dm_button_text branch July 2, 2024 11:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end low priority does not impact production code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant