Try to fix wrong urls for images in the related panels #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- instead of caching the html of the related components we now save the ids of the objects. They are then queried on each render
|
Since I changed this a few hours ago I didn't have the problem again -> ready for review |
melroy89
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to get rid of a problem with the "related" panels on the homepage. I observed this problem on gehirneimer.de where the images in entries and posts and the avatars of users would not load in the related panels (everywhere else the images were loading just fine). Reason for that wrong source URLs. I suspect that the way the cached components work the environment can be loaded wrongly, but I am not sure of the reason.
The caching before this PR for the panels would render the HTML of the components and put that HTML in our cache (redis).
After this PR only the IDs of the entries, posts and users are put in the cache and the components get rendered normally.
I have this PR running on gehirneimer and it has solved the image problem