connect mercure endpoint url to noti controller directly #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdfzdfj
force-pushed
the
refactor/noti-controller-endpoint-value
branch
from
eb8cb8b
to
0384ce8
Compare
melroy89
approved these changes
May 10, 2024
melroy89
added
enhancement
adjusted motification controller to take mercure endpoint url directly as controller values rather than templating the endpoint separately and then extracting them from dom nodes if the endpoint isn't provided then it will not attempt to connect to mercure, effectively disabling them also fix controller related js files according to eslint rules overall functionality should remain the same
asdfzdfj
force-pushed
the
refactor/noti-controller-endpoint-value
branch
from
0384ce8
to
0b787b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjusted notification controller to take mercure endpoint url directly as controller values rather than templating the endpoint separately and then extracting them from dom nodes
if the endpoint isn't provided then it will not attempt to connect to mercure, effectively disabling them
also fix controller related js files according to eslint rules
overall functionality should remain the same