Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front controller path/routing adjustment #687

Merged
merged 2 commits into from
May 15, 2024
Merged

front controller path/routing adjustment #687

merged 2 commits into from
May 15, 2024

Commits on May 15, 2024

  1. front controller path/routing adjustment 

    the new filter ui changes also introduces a couple more filtering
parameters in the form of controller path params, for threads/entries
listing it looks fine and relatively staightforward, but for microblog
posts listing, what used to be a simple `/microblog` is now something
like `/all/hot/∞/all/all/microblog`, which hinders the user experience
on url readability and memorability compared to the previous scheme, for
those who still care

this changes tries to adjust the path/routing of these front controller
especially for the microblog part, to make it more simpler and could
omit some default filter parameters if they aren't set, similar to the
previous path scheme

note that this patch main focus is just the path routing, there's
probably more to adjust/polish in front controller and related areas but
those would likely be a separate follow up patch
    @asdfzdfj
    asdfzdfj committed May 15, 2024
    Configuration menu
    Copy the full SHA
    0b4df4c View commit details
    Browse the repository at this point in the history

  2. make navbar strip type params when switching 

    Co-authored-by: e-five <[email protected]>
    @asdfzdfj @e-five256
    asdfzdfj and e-five256 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    8fb2fff View commit details
    Browse the repository at this point in the history