Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update symfony doctrine recipe to 2.11 #388

Merged
2 commits merged into from
Jan 2, 2024
Merged

Update symfony doctrine recipe to 2.11 #388

2 commits merged into from
Jan 2, 2024

Conversation

ghost
Copy link

@ghost ghost commented Dec 31, 2023 •
edited by ghost
Loading

No signs of regression during testing.

@ghost ghost added the dependencies Pull requests that update a dependency file label Dec 31, 2023
@ghost ghost requested a review from melroy89 December 31, 2023 16:03
@ghost ghost added the low priority does not impact production code label Dec 31, 2023
@ghost ghost changed the title Update symfony doctrine recipe to 2.11 removing deprecation warnings Update symfony doctrine recipe to 2.11 Jan 1, 2024
melroy89
melroy89 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@ghost ghost merged commit f7117b8 into main Jan 2, 2024
7 checks passed
@ghost ghost deleted the update_doctrine_2_11 branch January 2, 2024 21:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file low priority does not impact production code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@melroy89