Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign federation page #1181

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Redesign federation page #1181

merged 3 commits into from
Oct 10, 2024

Conversation

BentiGorlich
Copy link
Member

  • 3 different sections
  • TOC
  • always show panels with an empty notice when there are no entries

grafik

@BentiGorlich
Redesign federation page
8d7b774 
- 3 different sections
- TOC
- always show panels with an empty notice when there are no entries
@BentiGorlich BentiGorlich added enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end labels Oct 10, 2024
@BentiGorlich BentiGorlich self-assigned this Oct 10, 2024
@BentiGorlich BentiGorlich added this to the v1.7.3 milestone Oct 10, 2024
melroy89
melroy89 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@BentiGorlich BentiGorlich enabled auto-merge (squash) October 10, 2024 14:52
@melroy89
Copy link
Member

Hopefully an update like this merge branch main into.. will not remove the approval?

@BentiGorlich
Copy link
Member Author

@melroy89

The base branch requires all commits to be signed

@BentiGorlich
Copy link
Member Author

Hopefully an update like this merge branch main into.. will not remove the approval?

doesn't seem like it does

@melroy89
Copy link
Member

melroy89 commented Oct 10, 2024 •
edited
Loading

@melroy89

The base branch requires all commits to be signed

yea nice right..? I also try to enable that while I was there.. Not a good idea?

image

So your first commit doesn't seems to be signed:

image

@BentiGorlich BentiGorlich merged commit edb9130 into main Oct 10, 2024
7 checks passed
@BentiGorlich BentiGorlich deleted the new/redesign-federation-page branch October 10, 2024 15:00
@melroy89
Copy link
Member

@melroy89

The base branch requires all commits to be signed

yea nice right..? I also try to enable that while I was there.. Not a good idea?

image

So your first commit doesn't seems to be signed:

image

I guess I will disable this again.. but maybe a good thing to also enable soon...

@BentiGorlich
Copy link
Member Author

I just setup gpg signing on my end. Maybe in the future. I think this is a good idea in general. Don't know if it is necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melroy89 melroy89 melroy89 approved these changes

Assignees

@BentiGorlich BentiGorlich

Labels
enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
None yet
Milestone
v1.7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@BentiGorlich @melroy89