Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce the activity table #1173

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Introduce the activity table #1173

wants to merge 6 commits into from

Conversation

BentiGorlich
Copy link
Member

@BentiGorlich BentiGorlich commented Oct 7, 2024 •
edited
Loading

  • Save activities in the database so that they can be called via URL
  • Add unit tests for the JSON used in outward federation
  • Add functional tests for inbound federation
    • tests with our own JSON
    • tests with lemmy's JSON

Closes #772

@BentiGorlich BentiGorlich added enhancement New feature or request activitypub ActivityPub related issues backend Backend related issues and pull requests labels Oct 7, 2024
@BentiGorlich BentiGorlich added this to the v1.8.0 milestone Oct 7, 2024
@BentiGorlich BentiGorlich self-assigned this Oct 7, 2024
@BentiGorlich BentiGorlich force-pushed the new/dereferencable-activities branch from c444eeb to 57ec00a Compare October 7, 2024 19:14
@BentiGorlich BentiGorlich force-pushed the new/dereferencable-activities branch from cbcd898 to 49bdeaa Compare October 9, 2024 15:14
@melroy89

This comment was marked as outdated.

Sign in to view
@BentiGorlich BentiGorlich force-pushed the new/dereferencable-activities branch from 49bdeaa to 5c5f342 Compare November 19, 2024 22:24
@BentiGorlich BentiGorlich force-pushed the new/dereferencable-activities branch from ef0cc27 to e108c22 Compare November 24, 2024 11:14
@BentiGorlich BentiGorlich force-pushed the new/dereferencable-activities branch from e108c22 to 4d6b1ec Compare December 8, 2024 23:43
@BentiGorlich BentiGorlich force-pushed the new/dereferencable-activities branch from 4d6b1ec to 0ad5211 Compare December 10, 2024 11:06
@BentiGorlich BentiGorlich force-pushed the new/dereferencable-activities branch from 0ad5211 to 3ce355a Compare January 7, 2025 12:02
@BentiGorlich BentiGorlich force-pushed the new/dereferencable-activities branch from 3ce355a to 5729ac9 Compare January 7, 2025 12:49
@BentiGorlich BentiGorlich force-pushed the new/dereferencable-activities branch from 5729ac9 to 1bc2da1 Compare January 7, 2025 13:05
@BentiGorlich BentiGorlich force-pushed the new/dereferencable-activities branch from 1bc2da1 to ec9516b Compare January 7, 2025 14:32
@BentiGorlich BentiGorlich linked an issue Jan 13, 2025 that may be closed by this pull request
Like activity ID is not dereferencable #772
Open
@BentiGorlich BentiGorlich changed the base branch from dev/new_features to main January 14, 2025 15:31
@BentiGorlich BentiGorlich force-pushed the new/dereferencable-activities branch 2 times, most recently from 906898f to 30e3d86 Compare January 28, 2025 22:56
@BentiGorlich
Introduce the activity table
0b7fb28 
Whenever an actor makes an activity (like, announce, etc.) we now save it in our db, so the url we pass to other activity pub servers is valid and can return the correct json.
All the factory and wrapper classes now return an `Activity` entity that can be converted to json using the new `ActivityJsonBuilder`

# Conflicts:
#	src/MessageHandler/ActivityPub/Inbox/FollowHandler.php
#	src/MessageHandler/ActivityPub/Outbox/AnnounceLikeHandler.php
#	src/MessageHandler/ActivityPub/Outbox/FollowHandler.php
@BentiGorlich
Fix Flag and Follow Activity handling
40ad8a6
@BentiGorlich
Add AP outward json generation snapshot unit tests
da2e923 
� Conflicts:
�	composer.lock
�	tests/WebTestCase.php
@BentiGorlich
Fix tests after rebasing
3bf70de
@BentiGorlich BentiGorlich force-pushed the new/dereferencable-activities branch from 8b712aa to 3bf70de Compare February 5, 2025 10:09
@melroy89 melroy89 modified the milestones: v1.8.0, v1.8.1 Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BentiGorlich BentiGorlich

Labels
activitypub ActivityPub related issues backend Backend related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
v1.8.1
Development

Successfully merging this pull request may close these issues.

Like activity ID is not dereferencable
2 participants
@BentiGorlich @melroy89