-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce error pollution even more on post request failures #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
melroy89
force-pushed
the
reduce_error_pollution_more
branch
from
September 20, 2024 13:35
a4cbeb5
to
bfddfa6
Compare
melroy89
force-pushed
the
reduce_error_pollution_more
branch
from
September 20, 2024 13:35
bfddfa6
to
73d9c82
Compare
melroy89
commented
Sep 20, 2024
I'm running this for 4 days without any issues at kbin.melroy.org |
TheVillageGuy
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the 16th miscellaneous issue, with too much verbose error logging.
I try to handle the post request basically the same way as the previously implemented
InvalidApPostException
exceptions like in thegetCollectionObjectImpl
function.This meaning the content logging will be part of the catch ->
logRequestException
function instead. And theInvalidApPostException
exception will only log the request body, but no longer the response content. Also we log the status code now as well for failed post requests. Plus some small refactoring.Last but not least, I will only do a
json_encode
once.