Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check on empty/null filePath image #1128

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Check on empty/null filePath image #1128

merged 1 commit into from
Sep 13, 2024

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Sep 13, 2024 •
edited
Loading

Check if filePath is set, before continuing trying to resolve the image by LIIP.

Allowing to run: ./bin/console mbin:cache:build again.

Fixes the the eleventh issue of: #1119

@melroy89 melroy89 added bug Something isn't working enhancement New feature or request backend Backend related issues and pull requests labels Sep 13, 2024
@melroy89 melroy89 mentioned this pull request Sep 13, 2024
Open
23 tasks
@melroy89
Copy link
Member Author

I can confirm this fixed the issue.

@melroy89 melroy89 enabled auto-merge (squash) September 13, 2024 11:46
@melroy89 melroy89 merged commit f26b674 into main Sep 13, 2024
7 checks passed
@melroy89 melroy89 deleted the image_cache_build_command branch September 13, 2024 12:37
@melroy89 melroy89 added this to the v1.7.2 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BentiGorlich BentiGorlich BentiGorlich approved these changes

Assignees
No one assigned
Labels
backend Backend related issues and pull requests bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
v1.7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@melroy89 @BentiGorlich