-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 3.6] Fix compiler warnings in test_suite_pk.function #9274
[Backport 3.6] Fix compiler warnings in test_suite_pk.function #9274
Conversation
Signed-off-by: Elena Uziunaite <[email protected]>
Signed-off-by: Elena Uziunaite <[email protected]>
The Changelog entry should be included in the backport - and note that in the original PR it is missing a newline on the last line, even though GitHub doesn't give its usual warning icon there (maybe we should check for this explicitly in check_files, since it happens reasonably often?) |
We do. |
Signed-off-by: Elena Uziunaite <[email protected]>
Signed-off-by: Elena Uziunaite <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - faithful backport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@eleuzi01 Gentle reminder to apply relevant labels to your backport PRs as well :) (Noticed during triage.) |
Description
Trivial 3.6 backport of #9250
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.
Help make review efficient: