Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 3.6] Fix compiler warnings in test_suite_pk.function #9274

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

eleuzi01
Copy link
Contributor

Description

Trivial 3.6 backport of #9250

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog not required
  • 3.6 backport not required
  • 2.28 backport not required
  • tests not required

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

eleuzi01 added 2 commits June 17, 2024 15:55
Signed-off-by: Elena Uziunaite <[email protected]>
@tom-cosgrove-arm
Copy link
Contributor

The Changelog entry should be included in the backport - and note that in the original PR it is missing a newline on the last line, even though GitHub doesn't give its usual warning icon there (maybe we should check for this explicitly in check_files, since it happens reasonably often?)

@gilles-peskine-arm
Copy link
Contributor

missing a newline on the last line, even though GitHub doesn't give its usual warning icon there (maybe we should check for this explicitly in check_files

We do.

eleuzi01 added 2 commits June 18, 2024 10:27
Signed-off-by: Elena Uziunaite <[email protected]>
Signed-off-by: Elena Uziunaite <[email protected]>
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - faithful backport

Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eleuzi01 eleuzi01 added bug approved Design and code approved - may be waiting for CI or backports component-crypto Crypto primitives and low-level interfaces needs-ci Needs to pass CI tests size-xs Estimated task size: extra small (a few hours at most) labels Jun 18, 2024
@mpg
Copy link
Contributor

mpg commented Jun 19, 2024

@eleuzi01 Gentle reminder to apply relevant labels to your backport PRs as well :) (Noticed during triage.)

@eleuzi01 eleuzi01 removed the needs-ci Needs to pass CI tests label Jun 19, 2024
@paul-elliott-arm paul-elliott-arm added this pull request to the merge queue Jun 24, 2024
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit 9bfe69a Jun 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports bug component-crypto Crypto primitives and low-level interfaces size-xs Estimated task size: extra small (a few hours at most)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

6 participants