Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests/scripts/check_names.py to work for psa-crypto #8651

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

gabor-mezei-arm
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm commented Dec 21, 2023

Description

Resolve Mbed-TLS/TF-PSA-Crypto#52

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog not required, test framework
  • 3.6 backport ???
  • 2.28 backport not required, new feature
  • tests not required, already has

@gabor-mezei-arm gabor-mezei-arm added enhancement needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests size-s Estimated task size: small (~2d) component-test Test framework and CI scripts priority-high High priority - will be reviewed soon labels Dec 21, 2023
@gabor-mezei-arm gabor-mezei-arm self-assigned this Dec 21, 2023
Signed-off-by: Gabor Mezei <[email protected]>
@tom-daubney-arm tom-daubney-arm removed the needs-ci Needs to pass CI tests label Jan 3, 2024
@tom-daubney-arm
Copy link
Contributor

@gabor-mezei-arm Do I need to do anything special to get the check_names.py script to run in the TF-PSA-Crypto repository?

I have created a fresh clone of TF-PSA-Crypto based on the main branch, copied the modified check_names.py and build_tree.py scripts into it and tried to run the script but I am getting errors from the compilation stage.

Have I missed a key step to getting this to run, or should this just work?

@gabor-mezei-arm
Copy link
Contributor Author

Do I need to do anything special to get the check_names.py script to run in the TF-PSA-Crypto repository?

Currently the check_names.py is not working with the TF-PSA-Crypto repo because:

  • the development branch in the TF-PSA-Crypto repo is not building
  • it is using the config.py which is not ported yet

@tom-daubney-arm
Copy link
Contributor

Do I need to do anything special to get the check_names.py script to run in the TF-PSA-Crypto repository?

Currently the check_names.py is not working with the TF-PSA-Crypto repo because:

* the `development` branch in the `TF-PSA-Crypto` repo is not building

* it is using the `config.py` which is not ported yet

Ok thanks. I wasn't using the development branch however the errors I was getting were from config.py being missing so that all makes sense.

Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the comments on this PR, the script is not working with TF-PSA-Crypto and this is expected. The script does work as intended on Mbed TLS and all the code changes look sensible. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-test Test framework and CI scripts enhancement needs-review Every commit must be reviewed by at least two team members, priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Development

Successfully merging this pull request may close these issues.

Add name checks
2 participants