Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the MSVC versions supported by each branch #157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use the MSVC versions supported by each branch #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions vars/common.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,11 +307,19 @@ def check_every_all_sh_component_will_be_run(BranchInfo info) {
}

def get_supported_windows_builds() {
def vs_builds = []
def vs_builds
if (env.JOB_TYPE == 'PR') {
vs_builds = ['2013']
if (env.CHANGE_TARGET == 'mbedtls-2.28') {
vs_builds = ['2013']
} else {
vs_builds = ['2017']
}
} else {
vs_builds = ['2013', '2017']
if (env.MBED_TLS_BRANCH == 'mbedtls-2.28') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is MBED_TLS_BRANCH determined?

I fear that this approach will break if we make bugfix branches. Does it even work with security fixes that target mbedtls-2.28-restricted?

What we've done in the past was to read a file in the repository and base the testing on that. For example, at one point we had C89 branches tested with VS2010 and C99 branches tested with VS2013. See d4272ac and 5b1eb91.

By the way, that second commit suggests that we might need to change windows_testing.py too?

vs_builds = ['2013', '2015', '2017']
} else {
vs_builds = ['2017']
}
}
echo "vs_builds = ${vs_builds}"
return ['mingw'] + vs_builds
Expand Down