Fix generation of failures.csv when there are only non-outcome failures #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are failed builds but no failures recorded in outcomes.csv (for example, because all tests that can be built are passing, but some configurations fail to compile), `grep ';FAIL;'` returns 1. We still want to upload `outcomes.csv` in that case. Upload an empty failures.csv file in this case. An empty file isn't useful in itself, but having it makes looking at failed jobs a little more uniform. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
bug
mpg
approved these changes
Jan 23, 2024
| @@ -246,7 +246,7 @@ def process_outcomes() { | |||
| // as test description or test suite was "FAIL". | |||
| if (gen_jobs.failed_builds) { | |||
| sh '''\ | |||
| LC_ALL=C grep ';FAIL;' outcomes.csv >"failures.csv" | |||
| LC_ALL=C grep ';FAIL;' outcomes.csv >"failures.csv" || [ $? -eq 1 ] | |||
There was a problem hiding this comment.
Ah, nice. I'd have written || true but this is more precise, it only ignores the expected error where grep returns 1 for "no match". Learned something about robust sh scripting today :)
tom-cosgrove-arm
approved these changes
Jan 23, 2024
tom-cosgrove-arm
added
approved
|
I checked the CI results and they look good: the development run has an empty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a corner case from #144 that prevents the upload of
outcomes.csvwhen there are failed jobs but no failed test cases (e.g. all tests that compile are passing, but there are configurations where the compilation fails).Test run: