Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce PSA_CRYPTO_ECP_WITH_MPI_UINT config option #96

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

Introduce PSA_CRYPTO_ECP_WITH_MPI_UINT config option #96

wants to merge 4 commits into from

Conversation

tom-daubney-arm
Copy link
Contributor

Fixes #56

@tom-daubney-arm tom-daubney-arm added enhancement New feature or request priority-high High priority - will be reviewed soon needs-work labels Dec 14, 2023
@tom-daubney-arm tom-daubney-arm changed the base branch from main to development December 14, 2023 16:23
@tom-daubney-arm tom-daubney-arm force-pushed the psa_add_ecp_with_mpi_config_option branch 3 times, most recently from 0771ab4 to 523f2f4 Compare December 19, 2023 16:39
@tom-daubney-arm
Copy link
Contributor Author

tom-daubney-arm commented Dec 20, 2023 •
edited
Loading

Regarding the tests: I have compared the results from running component_test_default_gcc_asan_new_bignum in TF-PSA-Crypto with the results from the equivalent component in Mbed TLS and all the test suites that I expect to run are running. Additionally I have taken a look at the dependencies for the tests which depend on TF_PSA_CRYPTO_ECP_WITH_MPI_UINT and they also appear correct to me. Therefore, I believe everything is in order, and that this PR is ready for review.

@tom-daubney-arm tom-daubney-arm force-pushed the psa_add_ecp_with_mpi_config_option branch from 523f2f4 to 167a4b7 Compare December 20, 2023 14:44
@tom-daubney-arm tom-daubney-arm added needs-review Every commit must be reviewed by at least two team members and removed needs-work labels Dec 20, 2023
@tom-daubney-arm tom-daubney-arm marked this pull request as ready for review December 20, 2023 14:45
gabor-mezei-arm
gabor-mezei-arm approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabor-mezei-arm gabor-mezei-arm gabor-mezei-arm approved these changes

@ronald-cron-arm ronald-cron-arm Awaiting requested review from ronald-cron-arm

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request needs-review Every commit must be reviewed by at least two team members priority-high High priority - will be reviewed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PSA_CRYPTO_ECP_WITH_MPI_UINT config option
2 participants
@tom-daubney-arm @gabor-mezei-arm