Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PSA_CRYPTO_DEPRECATED_REMOVED/WARNING config options from Mbed TLS #95

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

Add PSA_CRYPTO_DEPRECATED_REMOVED/WARNING config options from Mbed TLS #95

wants to merge 4 commits into from

Conversation

tom-daubney-arm
Copy link
Contributor

Fixes #54

@tom-daubney-arm
Introduce deprecate warning and removed config options
65f539d 
Introduce the PSA_CRYPTO_DEPRECATED_WARNING and
PSA_CRYPTO_DEPRECATED_REMOVED config options to
mirror the similarly named options in Mbed TLS.

Signed-off-by: Thomas Daubney <[email protected]>
@tom-daubney-arm
Add configuration option translations
cdb62ac 
Add translation to Mbed TLS equivalent config options.

Signed-off-by: Thomas Daubney <[email protected]>
@tom-daubney-arm tom-daubney-arm added enhancement New feature or request priority-high High priority - will be reviewed soon needs-work labels Dec 12, 2023
@tom-daubney-arm tom-daubney-arm changed the base branch from main to development December 12, 2023 17:48
@tom-daubney-arm tom-daubney-arm force-pushed the psa_add_deprecated_config_options branch from 619cf4d to 3bebf27 Compare December 13, 2023 17:40
@tom-daubney-arm tom-daubney-arm added needs-review Every commit must be reviewed by at least two team members needs-reviewer This PR needs someone to pick it up for review and removed needs-work labels Dec 13, 2023
@tom-daubney-arm tom-daubney-arm marked this pull request as ready for review December 13, 2023 17:41
@tom-daubney-arm tom-daubney-arm force-pushed the psa_add_deprecated_config_options branch from 3bebf27 to 53c3465 Compare December 14, 2023 16:01
@tom-daubney-arm tom-daubney-arm force-pushed the psa_add_deprecated_config_options branch from 53c3465 to 2591b32 Compare December 14, 2023 16:25
gabor-mezei-arm
gabor-mezei-arm requested changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a typo found, otherwise LGTM.

drivers/builtin/include/mbedtls/config_adjust_mbedtls_from_tf_psa_crypto.h Outdated
Comment on lines 208 to 209


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for extra newlines.

@tom-daubney-arm
Remove superfluous new lines
8826469 
Signed-off-by: Thomas Daubney <[email protected]>
gabor-mezei-arm
gabor-mezei-arm approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-daubney-arm tom-daubney-arm removed the needs-reviewer This PR needs someone to pick it up for review label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabor-mezei-arm gabor-mezei-arm gabor-mezei-arm approved these changes

@ronald-cron-arm ronald-cron-arm Awaiting requested review from ronald-cron-arm

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request needs-review Every commit must be reviewed by at least two team members priority-high High priority - will be reviewed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PSA_CRYPTO_DEPRECATED_REMOVED/WARNING config options
2 participants
@tom-daubney-arm @gabor-mezei-arm