Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make legacy declarations private: macro guard, cipher #132

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

gilles-peskine-arm
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm commented Dec 23, 2024

Make legacy functions private by guarding their declaration with a macro.

As an example, do cipher.h (functions only, I didn't check if some macros and types should become private).

This is up for design review. There is no update to documentation yet. Some open questions:

  • Is this approach ok? It's a quick win for not having legacy functions declared .
  • Whether we want to update documentation at the same time we make things private, or later.
  • Whether we want to add changelog entries, and whether to do it incrementally or all at once at the end.

PR checklist

Guard private declarations in public headers with this macro.

Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm gilles-peskine-arm added priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) needs-design-approval Needs design discussion / approval needs-ci Needs to pass CI tests labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci Needs to pass CI tests needs-design-approval Needs design discussion / approval priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Projects
Development

Successfully merging this pull request may close these issues.

1 participant