Remove USE_PSA from standalone documentation #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBED_TLS_USE_PSA_CRYPTO is now always enabled we need to remove documentation discussing cases when it is disabled. Signed-off-by: Janos Follath <[email protected]>
MBED_TLS_USE_PSA_CRYPTO is now always enabled we need to remove documentation discussing cases when it is disabled. Signed-off-by: Janos Follath <[email protected]>
Some sentences or paragraphs became confusing or meaningless after removing USE_PSA and only fixing the local context/semantics. Fix the semantics where needed and remove parts that became meaningless. Signed-off-by: Janos Follath <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
This file has been deleted. Signed-off-by: Janos Follath <[email protected]>
There is not psa-limitations.md file in this project. Signed-off-by: Janos Follath <[email protected]>
yanesca
added
needs-review
Merged
5 tasks
gilles-peskine-arm
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
LGTM based on my previous review of pr_9818-2 (a874922cfc424a6555807e672be1f193c2843984) and checking the differences in the files that have moved to TF-PSA-Crypto:
git diff upstream-crypto/development upstream-crypto/pr/124 -- $(comm -23 <(git diff --name-only upstream-public/development...pr_9818-2 | sort) <(git ls-tree -r --name-only upstream-public/development | sort))
The diff is empty, and I did not expect further changes in this file.
waleed-elmelegy-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the crypto part of Mbed-TLS/mbedtls#9818. The last commit is the only new commit, the rest is a result of rebasing the original PR.
I checked for broken references like this: