-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final checklist pre-demo #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpatibility into final-bobbie-fixes
…s much data as possible
Xilophor
reviewed
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm, just a small change
LobbyCompatibility/Patches/SteamMatchmakingOnLobbyCreatedPostfix.cs
Outdated
Show resolved
Hide resolved
Xilophor
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
PresumablyCompatible
enumAfter this, the only thing that directly needs to be addressed before a demo is #12, which I already have a .txt file for.
I did not intend for this PR to have so many small things, please forgive me
Changes
LobbyCompatibility.Compatible
checks to support the new valuePresumablyCompatible
tooUnknown
, regardless of the plugin compatibility typesEveryone
mods)PresumedCompatible
to displayCompatible(?)
andPresumed Compatible
in the hover and full modlist panels respectivelyUnspecified
plugin compatibility header back toUnknown
, if we want to change unknown to unspecified we should do it project-wideUnknown
plugins with the same version on server/client implicitly compatibleUnknown
lobby type mod icons not showing as bright orangeLatestLobbyDiff
not returning the correct value if it was cachedmodded //
lobby string prefix to[MOD]
(Shorter lobby namechange behaviour #34)[MOD]
prefix from lobby names, while retaining the full 40 charactersConditional description text examples