Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final checklist pre-demo #49

Merged
merged 16 commits into from
Feb 29, 2024
Merged

Final checklist pre-demo #49

merged 16 commits into from
Feb 29, 2024

Conversation

legoandmars
Copy link
Collaborator

This PR:

  • Fixes up any UI bugs arising from the new PresumablyCompatible enum
  • Adds most of the minor features that need to be completed pre-demo
  • Fixes minor UI inconsistency that demoers would notice
  • Changes everything else that Change "Unknown" lobby behaviour to be more compatible #32 needs to be fulfilled

After this, the only thing that directly needs to be addressed before a demo is #12, which I already have a .txt file for.
I did not intend for this PR to have so many small things, please forgive me

Changes

  • Update hardcoded LobbyCompatibility.Compatible checks to support the new value PresumablyCompatible too
  • Made null server version always display "?" in the modlist when Lobby type is Unknown, regardless of the plugin compatibility types
  • Fix "CompatibleFirst" not putting compatible lobbies first if none were caught by the hashfilter (rarely there will be compatible lobbies not caught by the hashfilter, such as when the user has no Everyone mods)
  • Change PresumedCompatible to display Compatible(?) and Presumed Compatible in the hover and full modlist panels respectively
  • Rename Unspecified plugin compatibility header back to Unknown, if we want to change unknown to unspecified we should do it project-wide
  • Made Unknown plugins with the same version on server/client implicitly compatible
  • Made modlist scroll panel not shrink horizontally when it's too short for the scrollbar to appear
  • Fix Unknown lobby type mod icons not showing as bright orange
  • Fix LatestLobbyDiff not returning the correct value if it was cached
  • Change modded // lobby string prefix to [MOD] (Shorter lobby namechange behaviour #34)
  • Automatically removed [MOD] prefix from lobby names, while retaining the full 40 characters
  • Temporarily remove vanilla lobby join disable to ease transition period
  • Add conditional description text for when a lobby join fails

Conditional description text examples

image
image

@legoandmars legoandmars requested a review from Xilophor February 19, 2024 04:19
Copy link
Collaborator

@Xilophor Xilophor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, just a small change

@Xilophor Xilophor self-requested a review February 20, 2024 21:26
@Xilophor Xilophor merged commit 8251a6f into master Feb 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants