Fix same version unknown mods getting added twice

MaxWasUnavailable · Feb 19, 2024 · e02c8a2 · e02c8a2
1 parent 275d9ed
commit e02c8a2
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/LobbyCompatibility/Features/LobbyHelper.cs b/LobbyCompatibility/Features/LobbyHelper.cs
@@ -53,8 +53,10 @@ internal static LobbyDiff GetLobbyDiff(Lobby lobby, string? lobbyPluginString)
             if (lobbyPlugin.CompatibilityLevel == null || lobbyPlugin.VersionStrictness == null)
             {
                 var clientVersion = clientPlugin?.Version;
-                pluginDiffs.Add(new PluginDiff(clientVersion == lobbyPlugin.Version ? PluginDiffResult.Compatible : PluginDiffResult.Unknown, lobbyPlugin.GUID, clientVersion,
-                    lobbyPlugin.Version));
+                // Unknown mods with the same version are implicitly compatible, and will be added as compatible here
+                pluginDiffs.Add(new PluginDiff(
+                    clientVersion == lobbyPlugin.Version ? PluginDiffResult.Compatible : PluginDiffResult.Unknown,
+                    lobbyPlugin.GUID, clientVersion, lobbyPlugin.Version));
                 continue;
             }
 
@@ -92,8 +94,9 @@ internal static LobbyDiff GetLobbyDiff(Lobby lobby, string? lobbyPluginString)
             if (clientPlugin.CompatibilityLevel == null || clientPlugin.VersionStrictness == null)
             {
                 var lobbyVersion = lobbyPlugin?.Version;
-                pluginDiffs.Add(new PluginDiff(PluginDiffResult.Unknown, clientPlugin.GUID, clientPlugin.Version,
-                    lobbyVersion));
+                if (lobbyVersion != clientPlugin.Version)
+                    pluginDiffs.Add(new PluginDiff(PluginDiffResult.Unknown, clientPlugin.GUID, clientPlugin.Version,
+                        lobbyVersion));
                 continue;
             }