Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump
rosu-pp
tov1.1.0
which utilizesrosu-mods
to pass mods as arguments.Instead of the binding only allowing the
int
type for mods, now the type must coincide with the alias definitionsThat means, mods can be given either through their (legacy) bitflags, a string for acronyms, a "GameMod"
dict
, or a sequence whose items are either a "GameMod"dict
, a single acronym string, or bitflags for a single mod.A "GameMod"
dict
must have the item'acronym': str
and an optional item'settings': GameModSettings
.This should make it easy to pass along mods as they're given by the osu!api by simple using
json.loads(...)
to convert the JSON into a python object.