Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/albas improvements #644

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Commits on Jul 24, 2024

  1. Refractor to different state

    Also organised imports, changed to updating properties, no optional chaining, no nullish coalescing or undefined values unless strictly necessary (will test this later).
    loiddy committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    897cd88 View commit details
    Browse the repository at this point in the history
  2. Move functions out of main

    loiddy committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    3e7925f View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Configuration menu
    Copy the full SHA
    27873a6 View commit details
    Browse the repository at this point in the history
  2. Fix: emit settingsUpdated when there's no image loaded but settings h…

    …as changed.
    
    Parent needs to know that the settings were updated to update view.
    loiddy committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    9a64ec5 View commit details
    Browse the repository at this point in the history
  3. Improve setting cropper size bounds and checkSizeAndPosition (previou…

    …sly checkWithinCropperSizeBounds)
    
    - Changed how cropper size bounds are calculated.
    - Changed naming of scaled cropper state values to internal, as we now check all of them –static too– and they follow different rules.
    - Added hiding resize squares when static side and changed cursor in non hidden squares.
    - Deleted resetCropOnAspectRatio change (explained in the rules section of cropperPosition.utils in changes)
    - Change naming of checkWithinCropperSizeBounds to checkSizeAndPosition, and updated it to cover new behaviour explained in rules (see changes, cropperPosition.utils).
    - See rules in cropper position and cropper size bounds utils.
    loiddy committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    dbd76d9 View commit details
    Browse the repository at this point in the history
  4. Fix: Prevent code from running unless there's a change in img element…

    … size on resize window
    loiddy committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    7bf39eb View commit details
    Browse the repository at this point in the history
  5. Improve how cropper resizes

    - How it moves when resizing when maintain aspect ratio is true
    - Can resize when one internal static side is applied
    loiddy committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    cad2d0d View commit details
    Browse the repository at this point in the history
  6. Delete no longer used things

    loiddy committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    f7b0e7f View commit details
    Browse the repository at this point in the history