-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/albas improvements #644
Open
loiddy
wants to merge
8
commits into
Mawi137:master
Choose a base branch
from
loiddy:Feat/Albas-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jul 24, 2024
-
Also organised imports, changed to updating properties, no optional chaining, no nullish coalescing or undefined values unless strictly necessary (will test this later).
Configuration menu - View commit details
-
Copy full SHA for 897cd88 - Browse repository at this point
Copy the full SHA 897cd88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e7925f - Browse repository at this point
Copy the full SHA 3e7925fView commit details
Commits on Jul 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 27873a6 - Browse repository at this point
Copy the full SHA 27873a6View commit details -
Fix: emit settingsUpdated when there's no image loaded but settings h…
…as changed. Parent needs to know that the settings were updated to update view.
Configuration menu - View commit details
-
Copy full SHA for 9a64ec5 - Browse repository at this point
Copy the full SHA 9a64ec5View commit details -
Improve setting cropper size bounds and checkSizeAndPosition (previou…
…sly checkWithinCropperSizeBounds) - Changed how cropper size bounds are calculated. - Changed naming of scaled cropper state values to internal, as we now check all of them –static too– and they follow different rules. - Added hiding resize squares when static side and changed cursor in non hidden squares. - Deleted resetCropOnAspectRatio change (explained in the rules section of cropperPosition.utils in changes) - Change naming of checkWithinCropperSizeBounds to checkSizeAndPosition, and updated it to cover new behaviour explained in rules (see changes, cropperPosition.utils). - See rules in cropper position and cropper size bounds utils.
Configuration menu - View commit details
-
Copy full SHA for dbd76d9 - Browse repository at this point
Copy the full SHA dbd76d9View commit details -
Fix: Prevent code from running unless there's a change in img element…
… size on resize window
Configuration menu - View commit details
-
Copy full SHA for 7bf39eb - Browse repository at this point
Copy the full SHA 7bf39ebView commit details -
- How it moves when resizing when maintain aspect ratio is true - Can resize when one internal static side is applied
Configuration menu - View commit details
-
Copy full SHA for cad2d0d - Browse repository at this point
Copy the full SHA cad2d0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7b0e7f - Browse repository at this point
Copy the full SHA f7b0e7fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.