Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read_erp() function by @Fmarkham; fix read_payrolls(); clarify docs #263

Merged
merged 12 commits into from
Jan 25, 2025

Conversation

MattCowgill
Copy link
Owner

Additional changes to #261 to prepare for master

Closes #260

fmarkham and others added 6 commits January 14, 2025 21:09
* Initial version. Attempted to match style of read_cpi function.

* The sex parameter now accepts a vector of valid values
@MattCowgill MattCowgill marked this pull request as draft January 14, 2025 10:41
@MattCowgill MattCowgill self-assigned this Jan 14, 2025
@MattCowgill
Copy link
Owner Author

MattCowgill commented Jan 14, 2025

I have:

  • Added @fmarkham as a contributor
  • Iterated the version number
  • Ensured that the object returned from read_erp() includes an age column - @fmarkham pls confirm this is expected behaviour
  • Made minor changes to code style and idiom
  • Added unit tests

@MattCowgill
Copy link
Owner Author

closes #264

@MattCowgill MattCowgill marked this pull request as ready for review January 25, 2025 03:27
@MattCowgill MattCowgill changed the title Add read_erp() function by @Fmarkham Add read_erp() function by @Fmarkham; fix read_payrolls(); clarify docs Jan 25, 2025
@MattCowgill MattCowgill merged commit 9dcf82f into master Jan 25, 2025
7 checks passed
@MattCowgill MattCowgill deleted the read_erp branch January 25, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a read_erp()
2 participants