-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] test ABI breakage on 1.x branches #85
base: v1.x
Are you sure you want to change the base?
Conversation
Similar to #83 |
BTW, we also have to account for ABI changes that are fine: solely adding new symbols. For example, the |
The user who suggested |
260938c
to
d8f5f1e
Compare
Yeah I saw but I wasn't sure if it's adding or removing error cases. I'll add it here (and there) once I get it to detect ABI changes... |
eabb4ad
to
1d132ed
Compare
I would have thought so, yeah, at least renaming the |
I added more odd changes (following https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C++) and it still doesn't see anything :/ It's odd because it worked well on libebml. I also checked it's really comparing different builds of different libraries (changing the VERSION to 8.0.0 was detected from the symbolic links). |
415b753
to
c7ee5e3
Compare
No description provided.