Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] test ABI breakage on 1.x branches #85

Open
wants to merge 13 commits into
base: v1.x
Choose a base branch
from
Open

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Oct 8, 2022

No description provided.

@robUx4 robUx4 added build-system abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) labels Oct 8, 2022
@robUx4
Copy link
Contributor Author

robUx4 commented Oct 8, 2022

Similar to #83

@mbunkus
Copy link
Contributor

mbunkus commented Oct 8, 2022

BTW, we also have to account for ABI changes that are fine: solely adding new symbols. For example, the abidiff output comparing release 1.6.3 & 1.7.1 lists a lot of added symbol, and the exit code is 4, but those two are actually compatible.

@mbunkus
Copy link
Contributor

mbunkus commented Oct 8, 2022

The user who suggested abidiff also pointed to two examples. One of them uses a couple of CLI options, one of them that seem relevant to us, too: --no-added-symbols which addresses what I wrote above. Not sure about the others, though.

@robUx4 robUx4 force-pushed the 1x-abi-break-test branch 6 times, most recently from 260938c to d8f5f1e Compare October 8, 2022 14:36
@robUx4
Copy link
Contributor Author

robUx4 commented Oct 8, 2022

The user who suggested abidiff also pointed to two examples. One of them uses a couple of CLI options, one of them that seem relevant to us, too: --no-added-symbols which addresses what I wrote above. Not sure about the others, though.

Yeah I saw but I wasn't sure if it's adding or removing error cases. I'll add it here (and there) once I get it to detect ABI changes...

@robUx4
Copy link
Contributor Author

robUx4 commented Oct 8, 2022

@mbunkus aren't those changes ABI changes 1d132ed ? It doesn't detect them 😞

@mbunkus
Copy link
Contributor

mbunkus commented Oct 8, 2022

I would have thought so, yeah, at least renaming the GetParentCluster function. 😕

@robUx4
Copy link
Contributor Author

robUx4 commented Oct 8, 2022

I added more odd changes (following https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C++) and it still doesn't see anything :/ It's odd because it worked well on libebml.

I also checked it's really comparing different builds of different libraries (changing the VERSION to 8.0.0 was detected from the symbolic links).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) build-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants