Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: from event -> procedural + async context #137

Merged
merged 7 commits into from
Nov 7, 2023
Merged

refactor: from event -> procedural + async context #137

merged 7 commits into from
Nov 7, 2023

Conversation

joacoc
Copy link
Contributor

@joacoc joacoc commented Nov 6, 2023 •
edited
Loading

This is a big refactor.

  • Removes all the EventEmitters all around.
  • Replaces the events with procedural calls to the providers.
  • A new class is added AsyncContext to handle all the async calls to the context and have a correct error handling. More centralization in the context.
  • Separates the RunSQLCommand to its own file query.ts inside the providers folder. (We should do the same with Copy and Run)
  • Providers are now created inside the context.
  • Fixes issue about expired bear token.

@joacoc joacoc requested a review from bobbyiliev as a code owner November 6, 2023 22:29
@joacoc joacoc merged commit 831b0a6 into main Nov 7, 2023
1 check passed
@joacoc joacoc deleted the replace-event-driven-arch branch November 7, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbyiliev bobbyiliev bobbyiliev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joacoc @bobbyiliev