refactor: return reload status

MaterializeInc · Nov 7, 2023 · b87f251 · b87f251
1 parent 5836840
commit b87f251
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/context/asyncContext.ts b/src/context/asyncContext.ts
@@ -294,8 +294,8 @@ export default class AsyncContext extends Context {
             this.config.setProfile(name);
             this.environment = undefined;
             try {
-                await this.reloadContext();
-                return true;
+                const success = await this.reloadContext();
+                return success;
             } catch (err) {
                 this.handleErr(err, "Error reloading context.");
                 console.error("[AsyncContext]", "Error reloading context: ", err);
@@ -327,7 +327,7 @@ export default class AsyncContext extends Context {
      * Reloads the whole context.
      */
     private async reloadContext() {
-        this.isReadyPromise = new Promise((res, rej) => {
+        this.isReadyPromise = new Promise((res) => {
             const asyncOp = async () => {
                 try {
                     await this.loadContext();

diff --git a/src/test/suite/extension.test.ts b/src/test/suite/extension.test.ts
@@ -253,7 +253,7 @@ suite('Extension Test Suite', () => {
         const context: AsyncContext = await extension.activate();
 		const success = await context.setProfile("invalid_profile");
 
-		assert.ok(success === false);
+		assert.ok(!success);
 
 	}).timeout(10000);
 });