Change broker rewrite callback to handle resolution too #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@rjobanp, FYI there's no much test coverage in this repository (and CI is broken here anyway), so I pulled this into a Materialize PR: MaterializeInc/materialize#27965. That should give us tons of test coverage of this new code path. |
rjobanp
approved these changes
Jul 1, 2024
Instead of offering a callback that allows rewriting broker addresses before DNS resolution, offer a callback that handles the entire DNS resolution process. This is strictly more powerful than the previous callback. Users can still rewrite addresses before DNS resolution, if they so choose, but they can also plug in their own DNS resolver, or inspect and/or modify addresses after DNS resolution.
benesch
force-pushed
the
resolve-broker-addr
branch
from
3cc9109
to
70aa182
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of offering a callback that allows rewriting broker addresses before DNS resolution, offer a callback that handles the entire DNS resolution process. This is strictly more powerful than the previous callback. Users can still rewrite addresses before DNS resolution, if they so choose, but they can also plug in their own DNS resolver, or inspect and/or modify addresses after DNS resolution.