Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoding: Make allocations fallible #5

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

ParkMyCar
Copy link
Member

This PR makes allocations in the decoding path of a Message fallible. See tokio-rs#974 with more details for what exactly changed.

@ParkMyCar
Copy link
Member Author

Chatted with @antiguru about this. It might not have the exact intended effect, because it's possible jemalloc will successfully "allocate" memory by giving us virtual address space, and actually error on the push when we try to map that virtual space to physical. But it's at least no worse than what we have today

@ParkMyCar ParkMyCar merged commit c893677 into master Feb 2, 2024
5 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant