feat/server-esm-take-2-dnt #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I need to keep this around because it's how Lerna will version this package. But with the package.json that ends up being generated being controlled by dnt via build_npm.ts I thought it good to make the root package.json barebones to discourage future-me from trying to use npm again with this library.
MasterKale
added
package:browser
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates SimpleWebAuthn project to add the ability to use @simplewebauthn/server and @simplewebauthn/typescript-types for use in Deno. These packages will be maintained at the following URL:
https://deno.land/x/simplewebauthn
The NPM package output continues to support CommonJS and ECMAScript modules.
This should complete the goal of "adding ESM support to SimpleWebAuthn" as this PR ultimately unblocks use of this library in non-Node, ESM-first, Web-API-centric runtimes as well, like Deno, CloudFlare Workers, and Bun.
Supersedes PR #366 to address Issue #338.
Other Notes
.git-blame-ignore-revsin the root of the monorepo that can be used locally viagit blame --ignore-revs-file .git-blame-ignore-revs(the GitLens extension in VS Code has been set up to do this automatically.)deno fmtfor code formatting anddeno lintfor linting. As a result Prettier and ESLint have been removed.pnpmhas been introduced in response to Lerna deprecating itsbootstrapcommand for native package manager workspace support. pnpm will make sure local package linking using theworkspace:value will get mapped to a proper version as part ofpnpm publish.Breaking Changes
asyncmethods that return aPromise:generateRegistrationOptions()generateAuthenticationOptions()generateChallenge()(in@simplewebauthn/server/helpers)