Fix segment ratio function #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for your review @MassimoCimmino. |
- Corrected typos. - Removed warning for nSegments=1, since segment_ratios = [1.] is the only valid value in this case. - Added some comments. - Clarified the warning for factor < 1 to better inform the user on how to resolve the issue.
|
Merged, thank you @j-c-cook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The limit
0 < end_length_ratio < 0.5should apply to all cases.Also, in preparation for #153, we could consider here to allow
nSegments=2andnSegments=1(which would simply returnsegment_ratios=numpy.array([0.5, 0.5])andnumpy.array([1.0])). A warning will be required in these cases to warn the user that theend_length_ratioparameter is overwritten.closes #159