Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NILU new spectra edited #280

Merged
merged 5 commits into from
Mar 3, 2025
Merged

NILU new spectra edited #280

merged 5 commits into from
Mar 3, 2025

Conversation

JeanFromentNILU
Copy link
Contributor

No description provided.

New EI spectra
ESI (-) part.1
ESI (-) part.2
ESI (+) part.1
ESI (+) part.2
@sneumann
Copy link
Member

Hi, thanks for the new batch !
Rene is the authoritative source, but let me give some quick quesses from my side.

  • 32 records end with double-slash and an empty line, instead they should end with the last peak
//

The CH$SMILES expected means that the CH$ section is missing the SMILES (and InChI in case of NILU-NL0136 I checked)
AC$MASS_SPECTROMETRY: MS_TYPE MS1 should be just AC$MASS_SPECTROMETRY: MS_TYPE MS
Several files are lacking the AC$INSTRUMENT_TYPE: LC-ESI-QFT
Regarding the SPLASH in NILU-NL0134 we'd need to check if that is an inconsistency in the way they are calculated. Which SPLASH Implementation/Language are you using ?
Not flagged by the validation, but you have double space in AC$INSTRUMENT: QExactive Plus Orbitrap
That's all at my glimpse,
yours,
Steffen

@JeanFromentNILU
Copy link
Contributor Author

Hi Thanks, I will work on that later this week. For the Splash, I am retrieving them from PubChem using the WebChem package on R.
Best
Jean

@schymane
Copy link
Member

The SPLASH needs to be generated based on your spectral data, not retrieved from PubChem - the SPLASH is a hash of your peaks and should be unique. Perhaps this is why this is leading to problems. Steffen did implement a SPLASH algorithm in R though ... here's an overview in Gert's repo:
https://github.com/berlinguyinca/spectra-hash

@JeanFromentNILU
Copy link
Contributor Author

Yes sorry, I got confused I am using GetSplashR from R or the splash given by ChemVista

@schymane
Copy link
Member

OK good (phew) - that makes more sense!

@meier-rene
Copy link
Collaborator

I fixed the remaining issues. Here comes a report of issues I found:

  • AC$MASS_SPECTROMETRY: MS_TYPE MS1 -> AC$MASS_SPECTROMETRY: MS_TYPE MS
  • AC$MASS_SPECTROMETRY: MS_TYPE and AC$MASS_SPECTROMETRY: ION_MODE were missing in a few records
  • AC$COLLISIONENERGY -> AC$MASS_SPECTROMETRY: COLLISION_ENERGY
  • The chemical compound annotation of the "Dechlorane" family was not always correct or missing
    I fixed everything. Besides that there is a platform incompatibility of the line ending of the last line between windows and linux. I can easily fix that with a tool but it might be complicated to fix that from windows. Not much You or I can do about it.

@meier-rene meier-rene merged commit ba93c3b into MassBank:dev Mar 3, 2025
1 check failed
@JeanFromentNILU
Copy link
Contributor Author

Hi, Thanks you very much! I was going to work on it tomorrow but you were much quicker than me! Thanks a lot for the help.

Jean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants