Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix has many through relationship not working #903

Open
wants to merge 9 commits into
base: 2.0
Choose a base branch
from
Open

Fix has many through relationship not working #903

wants to merge 9 commits into from

Conversation

circulon
Copy link
Contributor

This PR issues with the HasManyThrough relationship to not return related models

Issues addressed:

  • eager loading did not work
  • related loading would only sometimes work
  • where_xxx of relation built incorrect query criteria

Other things

  • use vars for table names and beter readability
  • added some more metod docstrings
  • added tests to prove eager/related loading is working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmancuso josephmancuso Awaiting requested review from josephmancuso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@circulon @josephmancuso