New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close connection on rollback [MySQL] #870

Merged

josephmancuso merged 1 commit into MasoniteFramework:2.0 from felipehertzer:patch-1

Mar 5, 2024

Contributor

felipehertzer commented Feb 23, 2024

Hey @josephmancuso,

I found out that the rollback command has an issue of keeping the MySql connection open. Similar than #857

DB.begin_transaction()
QueryBuilder().table('user').update('status', 1)
DB.rollback()

I added a check to close the connection similar with the commit function.

Thank you.


          Mysql close the connection on rollback

378b8c3

josephmancuso approved these changes

View reviewed changes

josephmancuso merged commit e7defe2 into MasoniteFramework:2.0

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet