Fixed queryBuilder .all() test

MasoniteFramework · Sep 10, 2024 · 1ca31b1 · 1ca31b1
1 parent f4dda56
commit 1ca31b1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/masoniteorm/query/QueryBuilder.py b/src/masoniteorm/query/QueryBuilder.py
@@ -1975,9 +1975,11 @@ def all(self, selects=[], query=False):
         Returns:
             dictionary -- Returns a dictionary of results.
         """
+
         self.select(*selects)
+
         if query:
-            return self.to_sql()
+            return self
 
         result = self.new_connection().query(self.to_qmark(), self._bindings) or []
 

diff --git a/tests/sqlite/models/test_sqlite_model.py b/tests/sqlite/models/test_sqlite_model.py
@@ -108,7 +108,7 @@ def test_model_can_use_selects(self):
 
     def test_model_can_use_selects_from_methods(self):
         self.assertEqual(
-            SelectPass.all(["username"], query=True),
+            SelectPass.all(["username"], query=True).to_sql(),
             'SELECT "select_passes"."username" FROM "select_passes"',
         )