-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test_files content to packaging #27
base: master
Are you sure you want to change the base?
Conversation
Provide test_files content in the distribution so downstream packagers sourcing from PyPI can run all tests successfully. While here, also note Python 3.6 support, since that's what I'm using it with.
While packaging this for pkgsrc.org, which prefers sourcing distribution files via PyPI, I found the distribution file doesn't include the test_files directory, so six of the sixteen tests fail. It's preferable to include all test files for optional inclusion downstream. |
One of the Travis CI jobs failed, but apparently not for reasons relating to this change. It looks like a fundamental problem with Python 3.3 coverage: "RuntimeError: Python 3.4 or later is required." |
setup.py
Outdated
@@ -60,6 +61,7 @@ def run(self): | |||
'Programming Language :: Python :: 3', | |||
'Programming Language :: Python :: 3.3', | |||
'Programming Language :: Python :: 3.4', | |||
'Programming Language :: Python :: 3.5' | |||
'Programming Language :: Python :: 3.5', | |||
'Programming Language :: Python :: 3.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing comma? -> cleaner diffs down the road
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I could add that. (I just noted it works with 3.7 as well.) I hadn't done that because it didn't seem to be the original author's style.
The test suite passes on Python 3.7, and I've been using it with 3.7 successfully for months.
Provide test_files content in the distribution so downstream packagers sourcing from PyPI can run all tests successfully. While here, also note Python 3.6 support, since that's what I'm using it with.