Add POST to transparent S3 api #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pawel Sarbinowski <[email protected]>
uberspot
force-pushed
the
add_post_to_t_s3
branch
from
011325f to
c2bb85a
Compare
adrianchifor
approved these changes
Feb 3, 2022
Signed-off-by: Pawel Sarbinowski <[email protected]>
uberspot
force-pushed
the
add_post_to_t_s3
branch
from
f18caf4 to
2224827
Compare
Signed-off-by: Pawel Sarbinowski <[email protected]>
uberspot
force-pushed
the
add_post_to_t_s3
branch
from
d4ff0dd to
085f9e8
Compare
|
|
||
| resp, err := s3Client.CreateMultipartUpload(input) | ||
| if err != nil { | ||
| fmt.Println(err.Error()) |
There was a problem hiding this comment.
Suggested change
| fmt.Println(err.Error()) | |
| log.Errorf("Failed to create multipart upload: %v", err) |
| @@ -180,6 +182,35 @@ func transparentS3Put(c *gin.Context) { | |||
| c.String(200, "") | |||
| } | |||
|
|
|||
| func transparentS3Post(c *gin.Context) { | |||
| bucket := c.Param("bucket") | |||
| key := c.Param("key") | |||
There was a problem hiding this comment.
key and bucket need empty string checks
| resp, err := s3Client.CreateMultipartUpload(input) | ||
| if err != nil { | ||
| fmt.Println(err.Error()) | ||
| return |
There was a problem hiding this comment.
You need to set the context before returning, like c.String(500, "")
| return | ||
| } | ||
| log.Debugf("Response: ", resp) | ||
| c.XML(200, resp) |
There was a problem hiding this comment.
resp is a go struct, not XML https://docs.aws.amazon.com/sdk-for-go/api/service/s3/#CreateMultipartUploadOutput
It depends on what the multipart POST expects as a response, either you need a new XML struct in https://github.com/MarshallWace/cachenator/blob/master/s3_structs.go or a plain response like for transparent put c.String(200, "")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following example initiates a multipart upload by sending an HTTP POST request to the URI of the multipart-uploadsSeems to be part of the S3 api spec according to:
https://aws.amazon.com/premiumsupport/knowledge-center/s3-multipart-upload-cli/
and
https://github.com/apoorvam/aws-s3-multipart-upload/blob/master/aws-multipart-upload.go
But I'm not 100% confident how this will handle non-multi-part uploads too.