Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reverse Runs #2926

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Fix Reverse Runs #2926

merged 2 commits into from
Oct 15, 2024

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Oct 15, 2024

Problem

Reverse runs had a bizarre interaction with multiple instances of the JobRunItem rendered. This prevents the instability.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: phixMe <[email protected]>
@boring-cyborg boring-cyborg bot added the web label Oct 15, 2024
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit fc76d0a
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/670ee061f0666700084bb807

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.12%. Comparing base (bc74ef9) to head (fc76d0a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2926   +/-   ##
=========================================
  Coverage     81.12%   81.12%           
  Complexity     1505     1505           
=========================================
  Files           268      268           
  Lines          7358     7358           
  Branches        330      330           
=========================================
  Hits           5969     5969           
  Misses         1228     1228           
  Partials        161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc added this to the 0.50.0 milestone Oct 15, 2024
@wslulciuc wslulciuc merged commit 5ba7503 into main Oct 15, 2024
16 checks passed
@wslulciuc wslulciuc deleted the fix/reverse-logic branch October 15, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants