Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All routes now appear after dismissing RoutesDetail #193

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PalaashPandey
Copy link
Contributor

Describe your changes

All routes now appear after dismissing RoutesDetail

Issue number and link

#192

Dependency Changes

N/A

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have verified that any UI changes I have made work in dark mode
  • All of my GitHub checks have passed
  • I have added any new packages/updates above
  • I have verified that I am not submitting other changes/features outside the scope of my PR

Copy link
Member

@bwees bwees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you modify this so we arent storing the 3 groups of routes. Maybe add an onAnimate callback on the RoutesList sheet to run when it animates from -1 position. The main problem with storing the 3 groups is we have to constantly ensure that they all contain correct information (mainly when refreshing the list or updating routes). We want to make sure we arent adding more complexity especially when we are planning on adding more route providers.

@bwees
Copy link
Member

bwees commented Jan 20, 2025

Im also curious as to why this is only an android bug. Is the callback that handles this on iOS not running on android. In which case is there a callback that we can configure that works for both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants