add default LEVELING_COMMANDS for TOUCH_UI_FTDI_EVE #27667
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellensp
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FTDI EVE display fails to build when FTDI_LEVELING_MENU is enabled
It throws an error 'LEVELING_COMMANDS' not declared - did you mean 'BED_LEVELING_COMMANDS'? for /extui/ftdi_eve_touch_ui/generic/leling_menu.cpp
Code was updated in #27275
from
case 2: SpinnerDialogBox::enqueueAndWait(F("G34")); break;to
case 2: SpinnerDialogBox::enqueueAndWait(F(LEVELING_COMMANDS)); break;'They' added LEVELING_COMMANDS to their example Configuration_adv.h
https://gitlab.com/lulzbot3d/marlin/-/blob/master/Marlin/Configuration_adv.h#L4149
But forgot about everyone else
Added a default LEVELING_COMMAND set to "G34" as it was originally, but will allow Configuration files to change it.
Requirements
Lots, see attached example Configs
TOUCH_UI_FTDI_EVE, some form of probe, some form of bed leveling
Benefits
Builds as expected
Configurations
Configuration.zip
Related Issues