-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fan override and multiplier #27198
base: bugfix-2.1.x
Are you sure you want to change the base?
Fan override and multiplier #27198
Conversation
0238d69
to
1ddd078
Compare
This potentially adds another layer of complexity / possible points of confusion for users (bug reports and/or support requests) when a fan is "locked" since they won't know why standard fan commands aren't working. |
|
Do you consider these features worthy? If so I'll add configuration flags and maybe avoid the float operation in the multiplayer for slower boards. |
|
They now have to first enable the option in configuration_adv.h and then explicitly lock it from either UI or gcode. It is not persisted to eeprom either so I don't think this would be a problem anymore. |
# Conflicts: # Marlin/src/module/temperature.cpp # Marlin/src/module/temperature.h
236d06f
to
a3d16e0
Compare
Hi. I created a similar functionality. Perhaps joint work is possible.
I don't know if other uses of robotics (laser, cnc, or other), prefer percentage or decimal. That's why I will be really happy to have these two possibilities. Very good work Note: I made this thing without knowing that you had already done the same , I only found out afterwards, too bad because I would have adopted it (with a few modifications, of course :-)) |
Let's find the minimum options that get the job done :)
|
By the way, I didn't use percentage for the multiplier because the existing types use uint8_t so the max possible would be 255%. And they're most likely limited to 100% anyway |
The project is for you, I don't have time. You have two blocks of 'work', you can feel free to make what seems the best for you and all. |
This PR is ready for review then |
c792921
to
37fb26b
Compare
37d77d6
to
aa44542
Compare
Description
I recently installed cpap style remote cooling, and found I often wished to reduce or force the fan speed mid print, independent of what gcode calls to M106 are done.
This PR adds:
Obviously the PR is still missing configuration.h options, but I'd like to get early feedback or save myself the hassle if the feature is not considered good to merge (I use it and find it useful myself)Requirements
Part cooling fan.
Benefits
Avoid having to re-slice and restart a print when I find the current settings are not good mid-print.
Configurations
Related Issues