Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Fix ESP3D WiFi Support #26822

Merged

Conversation

thisiskeithb
Copy link
Member

Description

#26097 broke WiFi support for ESP3D on ESP32-based boards, so this PR brings back that functionality. See #26786 & luc-github/ESP3DLib#75 for more information.

CC: @luc-github

Requirements

ESP32-based motherboard with WiFi / ESP3DLib

Benefits

WiFi will work on these boards again.

Related Issues

@EmVee381
Copy link

it works for me, thx. why is it not in branch??

@thisiskeithb
Copy link
Member Author

it works for me, thx. why is it not in branch??

Because this PR has not been merged yet.

@EmVee381
Copy link

it works for me, thx. why is it not in branch??

Because this PR has not been merged yet.

yes, but why ? :) i don't understand that, i am new in this, i see there are no conflicts message for two weeks. thx

@thisiskeithb
Copy link
Member Author

yes, but why ?

There are nearly 100 PRs in the queue and these things take time.

@sjasonsmith sjasonsmith merged commit e675545 into MarlinFirmware:bugfix-2.1.x Apr 10, 2024
61 checks passed
@thisiskeithb thisiskeithb deleted the pr/fix_esp32-3d_wifi branch April 10, 2024 12:38
RPGFabi pushed a commit to RPGFabi/Marlin that referenced this pull request Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] No ESP3D_WIFISUPPORT on ESP32 in 2.1.2.2 and bugfix-2.1.x
3 participants